chore: fix angular-eslint versions and bump node.js on the CLI to v20.9.0 #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mpro7
commented
Jan 14, 2025
•
mpro7
commented
- downgrade angular-eslint deps to v17.3.0
- add Dependabot eslint rules
- set more precise node.js version on the CLI and bump it to 20.9.0
mpro7
changed the title
irmastnt
approved these changes
Jan 14, 2025
derschnee68
requested changes
Jan 14, 2025
| @@ -18,7 +18,7 @@ jobs: | |||
| fetch-depth: 0 # gets additionally all tags which we need | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 18 | |||
| node-version: 20.9.0 | |||
There was a problem hiding this comment.
what do you think about using a global variable for the node version ?
like node-version: {{NODE_VERSION}}
derschnee68
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.