fix: osd navigator 401 issue (DEV-4317) #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derschnee68
approved these changes
Nov 13, 2024
mpro7
reviewed
Nov 13, 2024
| @@ -50,13 +50,13 @@ export class StillImageComponent implements AfterViewInit, OnDestroy { | |||
| isPng = false; | |||
|
|
|||
| constructor( | |||
| protected osd: OpenSeaDragonService, | |||
| protected osdService: OpenSeaDragonService, | |||
There was a problem hiding this comment.
Why is this protected? Shouldn't also be private?
irmastnt
deleted the
feature/dev-4317-image-preview-for-internal-images-is-not-loaded-due-to-401
branch
irmastnt
added a commit
that referenced
this pull request
Nov 19, 2024
…-not-be-downloaded * main: fix: react on input changes (DEV-4370) (#1896) fix: open as side dialog (DEV-4226) (#1889) refactor: resource editor (DEV-4339) (#1890) chore: add cypress dependencies to project package.json (#1893) chore: ngxs comments, removed current page state (#1888) fix: osd navigator 401 issue (DEV-4317) (#1886) # Conflicts: # libs/vre/shared/app-representations/src/lib/still-image/still-image.component.ts # libs/vre/shared/app-resource-page/src/lib/compound/compound.service.ts # libs/vre/shared/app-state/src/lib/resource/resource.state.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-4317