Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image download (DEV-4321) (DEV-4318) #1885

Merged

Conversation

irmastnt
Copy link
Contributor

resolves DEV-4321, DEV-4318

@derschnee68 derschnee68 self-requested a review November 12, 2024 12:00
@domsteinbach domsteinbach self-requested a review November 12, 2024 14:10
Copy link
Contributor

@domsteinbach domsteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compound viewer does not pass any attachedProject to the image components. I also would prefer to get the attached project by a state.

@irmastnt
Copy link
Contributor Author

The compound viewer does not pass any attachedProject to the image components. I also would prefer to get the attached project by a state.

Should be ok now

irmastnt and others added 3 commits November 12, 2024 19:29
…-not-be-downloaded

* main:
  fix: react on input changes (DEV-4370) (#1896)
  fix: open as side dialog (DEV-4226) (#1889)
  refactor: resource editor (DEV-4339) (#1890)
  chore: add cypress dependencies to project package.json (#1893)
  chore: ngxs comments, removed current page state (#1888)
  fix: osd navigator 401 issue (DEV-4317) (#1886)

# Conflicts:
#	libs/vre/shared/app-representations/src/lib/still-image/still-image.component.ts
#	libs/vre/shared/app-resource-page/src/lib/compound/compound.service.ts
#	libs/vre/shared/app-state/src/lib/resource/resource.state.ts
@irmastnt irmastnt merged commit 4752285 into main Nov 19, 2024
14 checks passed
@irmastnt irmastnt deleted the feature/dev-4318-compound-resource-asset-can-not-be-downloaded branch November 19, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants