Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow JSON files as text files (DEV-4222) #1854

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat: Allow JSON files as text files (DEV-4222) #1854

merged 2 commits into from
Oct 15, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Oct 10, 2024

I uploaded one file locally, it worked.

@siers siers requested a review from derschnee68 October 10, 2024 09:56
@linear Linear
Copy link

linear bot commented Oct 10, 2024

DEV-4222 Allow uploading JSON files as assets

mpro7
mpro7 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting please :) and wait for someone else to confirm that this is the only one place to add. Most probably yes.

libs/vre/shared/app-resource-properties/src/lib/upload.component.ts Outdated Show resolved Hide resolved
@siers siers merged commit b6f698f into main Oct 15, 2024
14 checks passed
@siers siers deleted the feat/DEV-4222-json-text-files branch October 15, 2024 09:22
@daschbot daschbot mentioned this pull request Oct 15, 2024
Merged
irmastnt added a commit that referenced this pull request Oct 16, 2024
@irmastnt
Merge branch 'main' into feature/dev-2380-eu-view-an-existing-resource
b825455 
* main:
  feat: Allow JSON files as text files (DEV-4222) (#1854)
  chore(main): release 11.21.0 (#1833)
  refactor: add an isolated link resource component (#1849)
  chore(deps): bump @sentry/browser and @sentry/angular-ivy (#1846)
  fix: initialise with empty function, call onChange also if invalid (#1848)

# Conflicts:
#	package-lock.json
irmastnt added a commit that referenced this pull request Oct 17, 2024
@irmastnt
Merge branch 'main' into feature/dev-4227-seeing-existing-images-only…
1a6f818 
…-possibly-via-iiif-url-new-tab

* main:
  feat: Allow JSON files as text files (DEV-4222) (#1854)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 approved these changes

@derschnee68 derschnee68 Awaiting requested review from derschnee68

@irmastnt irmastnt Awaiting requested review from irmastnt

@domsteinbach domsteinbach Awaiting requested review from domsteinbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siers @mpro7