fix: display ontology labels in prefffered language (DEV-3739) #1651
Conversation
| matTooltipShowDelay="750" | ||
| [matTooltipPosition]="'above'" | ||
| [matTooltipDisabled]="tooltipDisabled"> | ||
| {{ resClass.label }} | ||
| {{ displayOntologyLabelsInPreferredLanguage() }} |
There was a problem hiding this comment.
I would not use a method in the view, as it calls it many many times during the rerender
| @@ -36,7 +37,7 @@ import { map, takeUntil } from 'rxjs/operators'; | |||
| export class OntologyClassItemComponent implements OnInit, AfterViewInit, OnDestroy { | |||
| destroyed: Subject<void> = new Subject<void>(); | |||
|
|
|||
| @Input() resClass: ClassDefinition; | |||
| @Input() resClass: ResourceClassDefinitionWithAllLanguages; | |||
There was a problem hiding this comment.
add "?" if it is not required, otherwise @input({required: true}) variable!;
| prefferedLanguage = l; | ||
| }); | ||
|
|
||
| if (this.resClass.labels) { |
There was a problem hiding this comment.
this should go in the subscribe
There was a problem hiding this comment.
const preferedLanguage = this._store.selectSnapshot(UserSelector.language);
| @@ -66,6 +67,8 @@ export class OntologyClassItemComponent implements OnInit, AfterViewInit, OnDest | |||
| }, | |||
| }; | |||
|
|
|||
| ontologiesLabel: string; | |||
There was a problem hiding this comment.
ontologiesLabel?: string;
| // https://github.com/dasch-swiss/dsp-das/pull/1651 | ||
| const prefferedLanguage = this._store.selectSnapshot(UserSelectors.language); | ||
|
|
||
| if (this.resClass.labels) { |
There was a problem hiding this comment.
so if this condition is not met, ontologiesLabel stays undefined, is that what we want ? (just asking I don't know what's the right behaviour)
There was a problem hiding this comment.
I think this is not necessary, because of the guard I added: this.resClass.labels[0].value. If there is no match between label languages and preferred language, the first one from the labels array is applied, and at least one label is required AFAIK.
…-preferred-language
mpro7
deleted the
dev-3739-labels-arent-displayed-in-the-users-preferred-language
branch
resolves DEV-3739