Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: highlighting image region after creating new one (#DEV-3700) #1632

Conversation

irmastnt
Copy link
Contributor

@irmastnt irmastnt commented Jun 3, 2024

fix: highlighting image region after creating new one (#DEV-3700)
prevents from loading resource list if removed resource is region

Copy link

linear bot commented Jun 3, 2024

Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Is the "canvas-click event doesnt work anymore" something that needs to be investigated?

@irmastnt irmastnt merged commit ec9807c into main Jun 3, 2024
13 checks passed
@irmastnt irmastnt deleted the feature/dev-3700-regions-are-not-displayed-correctly-when-clicked branch June 3, 2024 12:26
@irmastnt
Copy link
Contributor Author

irmastnt commented Jun 3, 2024

Looks reasonable. Is the "canvas-click event doesnt work anymore" something that needs to be investigated?

Probably. Reinitialising viewer after new resource is created is not very efficient. Anyhow this works, until better solution is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants