Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(erasing resource): reintroduce necessary comment #1581

Conversation

domsteinbach
Copy link
Contributor

resolves DEV-3627

Copy link

linear bot commented May 14, 2024

@domsteinbach domsteinbach requested a review from derschnee68 May 14, 2024 13:17
@domsteinbach domsteinbach marked this pull request as ready for review May 14, 2024 13:36
@@ -40,7 +58,7 @@ export class EraseResourceDialogComponent {
const payload = new DeleteResource();
payload.id = this.data.resource.res.id;
payload.type = this.data.resource.res.type;
payload.deleteComment = this.comment ?? '';
payload.deleteComment = this.eraseForm.get('comment')?.value;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typesafe

@derschnee68 derschnee68 merged commit f65fd44 into main May 14, 2024
10 checks passed
@derschnee68 derschnee68 deleted the feature/dev-3627-erasing-a-created-resource-as-project-admin-or-system-admin branch May 14, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants