-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(system component): don't dispatch loading state for users; faster loading, prevent reloads on tab change #1562
Conversation
… when loading all users, remove unnecessary load full
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@domsteinbach would you consider to adjust this code according to official material documentation: https://material.angular.io/components/tabs/overview#tabs-and-navigation
Also users should not be loaded when "System Administration" or "All projects" tab is opened (see screenshot). It should be loaded only when user clicks on "All Users" tab.
![image](https://private-user-images.githubusercontent.com/3883685/325192274-4dd3287a-86d5-4d95-b8fa-cf55846654e0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MzczMTAsIm5iZiI6MTczOTYzNzAxMCwicGF0aCI6Ii8zODgzNjg1LzMyNTE5MjI3NC00ZGQzMjg3YS04NmQ1LTRkOTUtYjhmYS1jZjU1ODQ2NjU0ZTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMTYzMDEwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9M2M4YzA5MTY2NWZlYmM0YTJhYjBmMGEzOTI4NThlMzM2NjA4NGVlNTlkZTIyZThhM2JmM2NjNzdkMDMzODU4ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.8OLjswpRCO0JlujOYKeVeEq3HEuktOpJZpXTnX3nt-8)
Funny, it was my very intention to not let the tabs route, as it is a really, really bad UX. I prefer to have things ready without any waiting time when someone is changing tabs in a ui. It was not expensive to preload the users imho, but of value. Otherwise, when the tabs are routing, it is annoying: When a user navigates to system, then there is another loading time for when the tab is changed to /users. The users list is also destroyed after changing the tab back. Every tab change will reload the projects/all the users with all the users images again and again (which needs to be fixed there of course). |
Thanks @domsteinbach. Its really better now. |
resolves DEV-3530