fix(ontology): fix regex pattern in ontology form (DSP-1139) #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilchenmann
requested review from
mdelez and
waychal
and removed request for
waychal and
mdelez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DSP-1139
We had an issue in the "create ontology" form. The regex didn't work as expected. As the DSP-API documentation says: "An ontology name must be a valid XML NCName. [...] A user-created ontology name may not start with the letter v followed by a digit". Special characters (incl. Umlauts etc), spaces and leading numbers are not allowed.
In this PR I fixed the regex and turned off the autocomplete (because it hides the error message below the field).