-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ontology): new cardinality workflow (DSP-1652) #455
Conversation
This is how it works at the moment: Screen.Recording.2021-06-04.at.11.07.44.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to test the functionality but my properties are not updating correctly in the resource class and for every action it gives me Bad request(400)
error.
am I doing something wrong here?
Screen.Recording.2021-06-05.at.15.09.16.mov
As mentioned already in one of the meetings, it doesn't work with the test data like the anything ontology. Because this ontology is already in use. It means that the properties have already data in it. You have to start from scratch and create your own example ontology. |
src/app/project/ontology/property-form/property-form.component.ts
Outdated
Show resolved
Hide resolved
It reloads the view when I connect to the API on the test-server (v13.9.1), but not when using the local instance (v13.9.2). It has nothing to do with the API version, but maybe with an async time issue and for sure with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done :)
resolves DSP-1652, DSP-1656 and DSP-976
This PR contains the new workflow to create resource class and to add properties. It means: the user creates first a resource class. Then s/he has to go to this resource class and add the properties one by one. The GUI order can be changed at any time. It's the first iteration that helps to create new resource classes and to add properties incl. the cardinality. The update of a cardinality of existing properties in a resource class will be part of the next iteration.
I had to clean up some old (or now outdated) components:
resource-class-form.service
and theresourceClassFormSub
because we have separated the cardinality from the resource-class. But I moved some of the general methods to handle the data in the ontology editor from this service to a new service calledontology.service
.resource-class-property-form.component
is not needed anymore, because we can use theproperty-form.component
to handle the cardinality.