-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable progress bar if search results are empty (DSP-1575) #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good for the fulltext search - just a little css position to change. However, I have tried the advanced search and here, nothing: no result, no message, no console log.. It may not be related but it should be investigated in case the display problem comes from this PR.
|
||
<!-- In case of 0 result --> | ||
<div class="no-results" *ngIf="!loading && numberOfAllResults === 0"> | ||
<p>Your search <span *ngIf="searchMode === 'fulltext'">- <strong> {{searchQuery}}</strong> -</span> did not match any documents.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this message should be centered in the middle of the page instead of being displayed on the left side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I have fixed the issue in commit 7d5443e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I test the advanced search, I get the results as before but the loading spiner is running whereas you have set it to false...
Screen.Recording.2021-05-25.at.14.48.40.mov
be1814f
to
2c7130f
Compare
resolves DSP-1575
@flavens When page is refreshed with search string in the url, it displays search results on the page but same search string is not displayed in the search input box.
This bug requires changes in dsp-ui-lib and can be fixed in separate PR.