Skip to content
This repository has been archived by the owner on Oct 9, 2022. It is now read-only.

Multistore unmerge #133

Merged
merged 62 commits into from
Dec 30, 2020
Merged

Multistore unmerge #133

merged 62 commits into from
Dec 30, 2020

Conversation

wuminzhe
Copy link
Contributor

No description provided.

@wuminzhe
Add mysql store
98cbf60
@wuminzhe
Refactor mmr client
bb60fd2
@wuminzhe
Remove shared
41efd96
@wuminzhe
Impl trim for mysql store
b4fd35e
@wuminzhe
Support both mysql and rocksdb
48c8e06
@wuminzhe
Readd import subcmd
11d56a1
@wuminzhe
Refactor and add more functions to mmr client
08b6ecd
@wuminzhe
Fix count cmd output text
d10db26
@wuminzhe
Move go interface to a standalone crate as a lib
23cad0d
@wuminzhe
Fix unused params
9a33643
@wuminzhe
Move default rocksdb path to conf.rs
47d21e2
@wuminzhe
Add crate scope errors
2b61cac
@wuminzhe
Clear unused crates in Cargo
0bc5d2e
@wuminzhe
Refactor api
0d74606
@wuminzhe
Auto creating mysql mmr table if not exist
cf7f611
@wuminzhe
Import from geth
2e2f8cd
@wuminzhe
build.rs for ffi crate
7bbbff4
@wuminzhe
Add api doc to readme
4030cce
@wuminzhe
Fix import from geth
80e78ba
@wuminzhe
Fix ffi
eeae2b3
@wuminzhe
Fix log
cf19e0f
@wuminzhe
Fix import geth path problem
4345731
@wuminzhe
Fix log
d7fad0e
@wuminzhe
Update readme
5213cda
@wuminzhe
Update readme
f7f3dc3
@wuminzhe
Update readme
3d14c29
@wuminzhe
Fix import log
af3235a
@wuminzhe
Remove build
2eb671a
@wuminzhe
Fix bug when import from a running geth
8795c3e
@wuminzhe
Set an env var to make build.rs run when build with llvm11
894fa85
@hackfisher
Copy link
Contributor

@xiaoch05 The tests after latest commit failed.

@wuminzhe I think this PR is still too large, need description documenting the main change sections.

@xiaoch05
Copy link
Collaborator

@xiaoch05 The tests after latest commit failed.

@wuminzhe I think this PR is still too large, need description documenting the main change sections.

Yes, the package is split into several packages.
So the test must be added for each package. The old test cases cannot be used anymore.

hackfisher
hackfisher suggested changes Dec 29, 2020
View reviewed changes
@xiaoch05
Copy link
Collaborator

@xiaoch05 The tests after latest commit failed.

@wuminzhe I think this PR is still too large, need description documenting the main change sections.

@hackfisher This PR I have only tested import and runner. Other features such as mmr_root, ethashproof, receipt are not tested. So please wait to merge it until I have added test cases for each package, and tessted all the APIs.

@wuminzhe
Copy link
Contributor Author

wuminzhe commented Dec 29, 2020 •
edited
Loading

@hackfisher @xiaoch05
API response changed, pls pay more attention and read the new apis section of README.md

@hackfisher hackfisher merged commit a8c1b0d into master Dec 30, 2020
@hackfisher hackfisher deleted the multistore-unmerge branch December 30, 2020 11:31
@hackfisher hackfisher mentioned this pull request Dec 30, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xiaoch05 xiaoch05 xiaoch05 left review comments

@hackfisher hackfisher hackfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wuminzhe @hackfisher @xiaoch05 @wi1dcard