Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

[BUG] use-setstate-synchronously doesn't recognize assert statements #1178

Closed
1 task
DetachHead opened this issue Feb 1, 2023 · 6 comments
Closed
1 task
Assignees
Labels
area-rules type: bug Something isn't working
Milestone

Comments

@DetachHead
Copy link

DetachHead commented Feb 1, 2023

Environment and configuration

DCM version: 5.5.1
Dart SDK version: 3.0.0-52.0.dev

Configuration
dart_code_metrics:
  extends:
    - package:dart_code_metrics/presets/all.yaml

What did you do?

await doThing();
assert(mounted);
setState(() => {}); // error: use-setstate-synchronously

What did you expect to happen?

no error

What actually happened?

use-setstate-synchronously error

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response

@DetachHead DetachHead added the type: bug Something isn't working label Feb 1, 2023
@incendial
Copy link
Member

Oh, considering you have 3.0.0, can you share how is your experience with DCM so far?

@DetachHead
Copy link
Author

I haven't encountered any problems, although I didn't use it for very long. I was just testing something unrelated and forgot to switch back

@incendial
Copy link
Member

Still, that's good to know, thank you!

@incendial
Copy link
Member

@Desdaemon hey, do you want to take a look or should I? If you don't have time, that's totally okay 👍

@Desdaemon
Copy link
Contributor

@Desdaemon hey, do you want to take a look or should I? If you don't have time, that's totally okay 👍

That'd be great, thanks. I've been having trouble finding free time recently.

@incendial incendial added the waiting for release Will be available after new version is released label Feb 3, 2023
@incendial incendial added this to the 5.6.0 milestone Feb 3, 2023
@incendial
Copy link
Member

Available in 5.6.0 🚀

@incendial incendial removed the waiting for release Will be available after new version is released label Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants