fix: handle await inside conditions

Author: incendial

lib/src/analyzers/lint_analyzer/rules/rules_list/use_setstate_synchronously/use_setstate_synchronously_rule.dart

@@ -11,15 +11,15 @@ import '../../../models/severity.dart';
 import '../../models/flutter_rule.dart';
 import '../../rule_utils.dart';
 
+part 'config.dart';
 part 'fact.dart';
 part 'helpers.dart';
-part 'config.dart';
 part 'visitor.dart';
 
 class UseSetStateSynchronouslyRule extends FlutterRule {
   static const ruleId = 'use-setstate-synchronously';
 
-  Set<String> methods;
+  final Set<String> methods;
 
   UseSetStateSynchronouslyRule([Map<String, Object> options = const {}])
       : methods = readMethods(options),

lib/src/analyzers/lint_analyzer/rules/rules_list/use_setstate_synchronously/visitor.dart

@@ -2,6 +2,7 @@ part of 'use_setstate_synchronously_rule.dart';
 
 class _Visitor extends RecursiveAstVisitor<void> {
   final Set<String> methods;
+
   _Visitor({required this.methods});
 
   final nodes = <SimpleIdentifier>[];
@@ -72,6 +73,8 @@ class _AsyncSetStateVisitor extends RecursiveAstVisitor<void> {
       return node.visitChildren(this);
     }
 
+    node.condition.accept(this);
+
     final newMounted = _extractMountedCheck(node.condition);
     mounted = newMounted.or(mounted);
 
@@ -105,7 +108,7 @@ class _AsyncSetStateVisitor extends RecursiveAstVisitor<void> {
       return node.visitChildren(this);
     }
 
-    node.condition.visitChildren(this);
+    node.condition.accept(this);
 
     final oldMounted = mounted;
     final newMounted = _extractMountedCheck(node.condition);
@@ -127,7 +130,7 @@ class _AsyncSetStateVisitor extends RecursiveAstVisitor<void> {
       return node.visitChildren(this);
     }
 
-    node.forLoopParts.visitChildren(this);
+    node.forLoopParts.accept(this);
 
     final oldInControlFlow = inControlFlow;
     inControlFlow = true;
@@ -181,7 +184,7 @@ class _AsyncSetStateVisitor extends RecursiveAstVisitor<void> {
       return node.visitChildren(this);
     }
 
-    node.expression.visitChildren(this);
+    node.expression.accept(this);
 
     final oldInControlFlow = inControlFlow;
     inControlFlow = true;

test/src/analyzers/lint_analyzer/rules/rules_list/use_setstate_synchronously/examples/example.dart

@@ -95,7 +95,17 @@ class _FooState extends State<StatefulWidget> {
       await fetch();
     }
     setState(() {}); // LINT
+
+    if (!mounted) return;
+
+    if (await condition()) {
+      setState(() {}); // LINT
+    }
   }
 }
 
 class State {}
+
+Future<void> fetch() {}
+
+Future<bool> condition() {}

test/src/analyzers/lint_analyzer/rules/rules_list/use_setstate_synchronously/use_setstate_synchronously_rule_test.dart

@@ -32,8 +32,8 @@ void main() {
 
       RuleTestHelper.verifyIssues(
         issues: issues,
-        startLines: [7, 24, 29, 36, 51, 66, 70, 76, 82, 92, 97],
-        startColumns: [9, 10, 7, 7, 5, 7, 5, 5, 5, 5, 5],
+        startLines: [7, 24, 29, 36, 51, 66, 70, 76, 82, 92, 97, 102],
+        startColumns: [9, 10, 7, 7, 5, 7, 5, 5, 5, 5, 5, 7],
         locationTexts: [
           'setState',
           'setState',
@@ -46,6 +46,7 @@ void main() {
           'setState',
           'setState',
           'setState',
+          'setState',
         ],
         messages: [
           "Avoid calling 'setState' past an await point without checking if the widget is mounted.",
@@ -59,6 +60,7 @@ void main() {
           "Avoid calling 'setState' past an await point without checking if the widget is mounted.",
           "Avoid calling 'setState' past an await point without checking if the widget is mounted.",
           "Avoid calling 'setState' past an await point without checking if the widget is mounted.",
+          "Avoid calling 'setState' past an await point without checking if the widget is mounted.",
         ],
       );
     });