Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Commit 3130a85

Browse files
authored
fix: list-all-equatable-fields should be typed common (#1141)
1 parent d0613f4 commit 3130a85

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

lib/src/analyzers/lint_analyzer/rules/rules_list/list_all_equatable_fields/list_all_equatable_fields_rule.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ import '../../../lint_utils.dart';
1111
import '../../../models/internal_resolved_unit_result.dart';
1212
import '../../../models/issue.dart';
1313
import '../../../models/severity.dart';
14-
import '../../models/flutter_rule.dart';
14+
import '../../models/common_rule.dart';
1515
import '../../rule_utils.dart';
1616

1717
part 'visitor.dart';
1818

19-
class ListAllEquatableFieldsRule extends FlutterRule {
19+
class ListAllEquatableFieldsRule extends CommonRule {
2020
static const ruleId = 'list-all-equatable-fields';
2121

2222
ListAllEquatableFieldsRule([

test/src/analyzers/lint_analyzer/rules/rules_list/list_all_equatable_fields/list_all_equatable_fields_rule_test.dart

+18
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import 'package:dart_code_metrics/src/analyzers/lint_analyzer/models/severity.dart';
2+
import 'package:dart_code_metrics/src/analyzers/lint_analyzer/rules/models/rule_type.dart';
3+
import 'package:dart_code_metrics/src/analyzers/lint_analyzer/rules/rule_utils.dart';
24
import 'package:dart_code_metrics/src/analyzers/lint_analyzer/rules/rules_list/list_all_equatable_fields/list_all_equatable_fields_rule.dart';
35
import 'package:test/test.dart';
46

@@ -8,6 +10,22 @@ const _examplePath = 'list_all_equatable_fields/examples/example.dart';
810

911
void main() {
1012
group('ListAllEquatableFieldsRule', () {
13+
test('is of type common', () {
14+
expect(
15+
ListAllEquatableFieldsRule().type,
16+
equals(RuleType.common),
17+
);
18+
});
19+
20+
test('has expected documentation path', () {
21+
final documentationUri = documentation(ListAllEquatableFieldsRule());
22+
23+
expect(
24+
documentationUri.path,
25+
equals('/docs/rules/common/list-all-equatable-fields'),
26+
);
27+
});
28+
1129
test('initialization', () async {
1230
final unit = await RuleTestHelper.resolveFromFile(_examplePath);
1331
final issues = ListAllEquatableFieldsRule().check(unit);

0 commit comments

Comments
 (0)