Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

NgShow should be adding or removing the ng-hide class, not ng-show #518

Closed
bgourlie opened this issue Feb 6, 2014 · 2 comments
Closed

NgShow should be adding or removing the ng-hide class, not ng-show #518

bgourlie opened this issue Feb 6, 2014 · 2 comments

Comments

@bgourlie
Copy link
Contributor

bgourlie commented Feb 6, 2014

Per http://docs.angularjs.org/api/ng.directive:ngShow

As it stands now, NgShow is adding and removing an ng-show class which makes it ineffective. It should be adding and removing the ng-hide class.
@bgourlie
Copy link
Contributor Author

bgourlie commented Feb 6, 2014

I should be able to submit a PR for this tomorrow.

@bgourlie bgourlie mentioned this issue Feb 6, 2014
Closed
@mhevery
Copy link
Contributor

mhevery commented Feb 12, 2014

Fixed in 81fce7c

@mhevery mhevery closed this as completed Feb 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ngShow): Add/remove ng-hide class instead of ng-show class
2 participants
@mhevery @bgourlie