Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement cookie slot #151

Merged
merged 5 commits into from
Oct 21, 2023
Merged

feat: implement cookie slot #151

merged 5 commits into from
Oct 21, 2023

Conversation

darioferderber
Copy link
Collaborator

📚 Description

Resolves #150

📝 Checklist

  • All commits follow the Conventional Commit format
  • The PR's title follows the Conventional Commit format

dargmuesli
dargmuesli reviewed Oct 16, 2023
View reviewed changes
Copy link
Owner

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Some code formatting seems to be necessary to make the pipeline turn green.

@darioferderber
Copy link
Collaborator Author

😬 it's fixed now 🙂

dargmuesli
dargmuesli reviewed Oct 16, 2023
View reviewed changes
Copy link
Owner

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some explanation on what's the goal behind this slot? Just for people to understand without having to dig through the implementation.

@dargmuesli dargmuesli self-requested a review October 20, 2023 19:28
dargmuesli
dargmuesli approved these changes Oct 21, 2023
View reviewed changes
Copy link
Owner

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dargmuesli dargmuesli merged commit 782c1b9 into master Oct 21, 2023
@dargmuesli dargmuesli deleted the feat/cookie-slot branch October 21, 2023 22:59
dargmuesli pushed a commit that referenced this pull request Oct 21, 2023
@semantic-release-bot
chore(release): 6.5.0 [skip ci]
c0494b2 
## [6.5.0](6.4.6...6.5.0) (2023-10-21)

### Features

* implement cookie slot ([#151](#151)) ([782c1b9](782c1b9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dargmuesli dargmuesli dargmuesli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement "cookie" slot
2 participants
@darioferderber @dargmuesli