Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network range migration] Connect all DAppNode packages to the two docker networks #951

Closed
3alpha opened this issue Feb 2, 2022 · 6 comments
Assignees
Labels
networking Tasks related to networking P2 Worth doing eventually, no rush security

Comments

@3alpha
Copy link
Member

3alpha commented Feb 2, 2022

Intro

Currently, DAppNode internally uses 172.33.0.0/16 network range which is designated as public. It would be good to move away from that range so that any issues arising from that are avoided.

  • private network name: dnprivate_network
  • private network range: 10.20.0.0/24

Since DAppNode is highly modular system, migration will have to be done in multiple steps:

  • Connect all DAppNode packages to the two docker networks
    • docker connect immediately on start + update the compose of the two issue
  • Upgrade DNS resolver to use new network range
  • Upgrade all packages that serve as access methods to the new range
  • Test
  • Test
  • Remove old network

This issue concerns step one which will be starting point for all others steps.

Features expected

DAppManager connects itself and all other packages to the new docker network in the same manner it connects it self to the existing dncore_network.

@alexpeterson91
Copy link
Member

10.20.0.0/24 will be the new range correct? the one already baked into wireguard?

@3alpha
Copy link
Member Author

3alpha commented Feb 5, 2022

That is the plan, yes. Maybe we could've chosen block wiser both in terms of size and location.

@MysticRyuujin
Copy link

Why not either a) drop down to 172.32.0.0/16 or b) use a /16 off the 10.20.0.0?

Heck even better, make it configurable on initial setup for those of us with real networks where we might already use these ranges?

@alexpeterson91
Copy link
Member

alexpeterson91 commented Feb 6, 2022 via email

@pablomendezroyo
Copy link
Contributor

pablomendezroyo commented May 17, 2022

Another thing very important to take into account is that when moving to the new docker network dnprivate_network, the BIND container will have a different container IP than the current one 172.33.1.2. This IP is used in all the packages docker-compose files at the compose key dns

@pablomendezroyo
Copy link
Contributor

IP range migration already implemented! needs to be published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
networking Tasks related to networking P2 Worth doing eventually, no rush security
Projects
None yet
Development

No branches or pull requests

4 participants