Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other dictionaries #69

Open
danielt998 opened this issue May 11, 2020 · 5 comments
Open

Support other dictionaries #69

danielt998 opened this issue May 11, 2020 · 5 comments

Comments

@danielt998
Copy link
Owner

We should support other Dictionaries, for example CedPane and CC-CANTO

@james-s-w-clark
Copy link
Collaborator

How would the user choose?
Would we supply multiple definitions (which may be very similar)?
If CC-CEDICT has traditional characters too, what does CC-CANTO bring to the table?

@james-s-w-clark
Copy link
Collaborator

When talking about other dictionaries, it also makes me question if we should change our Word record from:

  • simp, trad, pinyin, def
    to

  • L2-1, L2-2, .... L2-N, L1 def

I was using this approach for GradedReaderBuilder to try to give general language support.
If we adopted more general phrasing and changed the project name, we could generalise to any dictionary and any input text (if we have material with suitable licenses).

@danielt998
Copy link
Owner Author

danielt998 commented May 11, 2020

How would the user choose?

for something like Cedpane it would be in addition to CC-CEDICT though there could be an option to enable/disable certain ones
For Cantonese, it would be a whole different thing, you'd want an option on the main screen for Cantonese/Mandarin (and maybe different romanisation systems too)

Would we supply multiple definitions (which may be very similar)?

I don't know, maybe so?

If CC-CEDICT has traditional characters too, what does CC-CANTO bring to the table?

Umm you know, CANTONESE PRONUNCIATION

@james-s-w-clark
Copy link
Collaborator

I think if users are interfacing with the backend through a web app, they could do checkboxes for which pronounciations they'd like (Mandarin, Cantonese, etc.).
The backend would just have all dictionaries (so long as the licenses are OK), and would add one or more pronounciation fields based on the user's selections on the web form.

I think let's do this later, but would be fun to first enrich our Words and then to enrich the flashcard output

@james-s-w-clark
Copy link
Collaborator

Sounds like we may need a generic Extractor/Dictionary interface ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants