Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling set-init! when not using :auto #96

Closed
martinklepsch opened this issue Sep 16, 2016 · 2 comments
Closed

Calling set-init! when not using :auto #96

martinklepsch opened this issue Sep 16, 2016 · 2 comments

Comments

@martinklepsch
Copy link

I got caught by surprise that set-init! isn't called when not using the :auto option. Is there any specific reasoning behind this? Maybe we could move the set-init call outside of the (when auto ...) check?

https://github.com/danielsz/system/blob/master/src/system/boot.clj#L55-L71
@danielsz
Copy link
Owner

danielsz commented Sep 20, 2016 •
edited
Loading

Yes, you are right. This is actually a regression, because that's how it worked. If auto is false, user should be able to start and stop manually at the REPL.
Will take care of it. Thanks!

@martinklepsch martinklepsch mentioned this issue Sep 20, 2016
Closed
@danielsz
Copy link
Owner

Fixed in 0.3.2-SNAPSHOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinklepsch @danielsz