Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent mode with optional tunnel type (user or kernel) #542

Open
stoktamisoglu opened this issue Jan 6, 2025 · 3 comments
Open

Agent mode with optional tunnel type (user or kernel) #542

stoktamisoglu opened this issue Jan 6, 2025 · 3 comments

Comments

@stoktamisoglu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Experimental agent mode with ENABLE_GO_IOS_AGENT=yes strats a kernel mode tunnel. It is necessary to give an option to start the tunnel in userspace.

If there is no specific reason to stay in experimental mode, we can also refactor the code to make it a feature.

Describe the solution you'd like
This is open to discussion. The easiest way may be renaming the environment variable something like ENABLE_GO_IOS_AGENT_WITH and the values might be "user" or "kernel". Then the code will handle to start appropriate tunnel type.

Describe alternatives you've considered
It may be part of options but this may require a lot of refactoring work.

Additional context
This experimental mode is a good feature for multiple device test automation.

@shamanec
Copy link
Collaborator

shamanec commented Jan 6, 2025

I think better yet if just the environment variable itself contains the tunnel type like ENABLE_GO_IOS_AGENT=kernel and ENABLE_GO_IOS_AGENT=userspace, then it will probably be just a simple check in main.go

@stoktamisoglu
Copy link
Contributor Author

I agree with you @shamanec. Will implement it and copy the PR here. Thx.

@stoktamisoglu
Copy link
Contributor Author

Hi @shamanec , would you please review #544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants