Error clicking nodes composed of mdi-react icons

[zerans]

Describe the bug
When using an icon from mdi-react in a node, clicking the node throws an error.

Looks like the offending code is here:

      if (e.target.tagName.toUpperCase() === "SVG" && e.target.attributes.name.value === "svg-container-" + _this.state.id) {
        _this.props.onClickGraph && _this.props.onClickGraph();
      }

The icon node is SVG, but doesn't have a name attribute.

To Reproduce

1. Configure a graph with a viewGenerator like this, where AlertIcon is imported from mdi-react

        viewGenerator: (node) => (<AlertIcon/>),

2. Click a few nodes on the graph (might take a few clicks for some reason)

3. Observe error:

Graph.js:442 Uncaught TypeError: Cannot read property 'value' of undefined
    at Graph._this.onClickGraph (Graph.js:442)
    at HTMLUnknownElement.callCallback (react-dom.development.js:147)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:196)
    at invokeGuardedCallback (react-dom.development.js:250)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:265)
    at executeDispatch (react-dom.development.js:571)
...

Expected behavior
The onClickNode handler should be called

Environment:

• OS: macOS
• Browser: Chrome
• Version: 74
• react-d3-graph version [email protected]

[danielcaldas]

Hi @zerans thanks for reporting, will look into it asap, in the meantime if anyone wants to take a look at it It just a matter of making sure that this e.target.attributes.name.value is accessible by checking for the existence of the property.

[danielcaldas]

Released in [2.1.0](Released in 2.1.0 🎉) 🎉