Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure schemaKeys are set properly #68

Merged
merged 1 commit into from
Jul 28, 2021
Merged

ensure schemaKeys are set properly #68

merged 1 commit into from
Jul 28, 2021

Conversation

satra
Copy link
Member

@satra satra commented Jul 28, 2021

No description provided.

@satra satra added patch Increment the patch version when merged release Create a release when this pr is merged labels Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #68 (a1b0e34) into master (8201cd7) will decrease coverage by 0.12%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   96.14%   96.02%   -0.13%     
==========================================
  Files          13       13              
  Lines        1298     1309      +11     
==========================================
+ Hits         1248     1257       +9     
- Misses         50       52       +2     
Flag Coverage Δ
unittests 96.02% <86.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/models.py 93.77% <75.00%> (-0.34%) ⬇️
dandischema/consts.py 100.00% <100.00%> (ø)
dandischema/tests/test_models.py 95.80% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f4f78...a1b0e34. Read the comment docs.

@satra satra merged commit 00c022b into master Jul 28, 2021
@satra satra deleted the fix/schemakey-basetype branch July 28, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant