Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only attempt to remove contributorType if present #37

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Conversation

dchiquito
Copy link
Contributor

Fixes #36

@satra I think this will resolve the issue.

@dchiquito dchiquito requested a review from satra June 16, 2021 18:52
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #37 (613124f) into master (0631f4d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files          11       11           
  Lines         879      879           
=======================================
  Hits          832      832           
  Misses         47       47           
Flag Coverage Δ
unittests 94.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/datacite.py 93.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0631f4d...613124f. Read the comment docs.

dandischema/datacite.py Outdated Show resolved Hide resolved
Co-authored-by: Satrajit Ghosh <[email protected]>
@dchiquito dchiquito added the bug Something isn't working label Jun 16, 2021
@satra satra merged commit 075d8f7 into master Jun 16, 2021
@satra satra deleted the bug-fix-doi branch June 16, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error generating DOI
2 participants