Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Orcid ID to the contributors #111

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Conversation

djarecka
Copy link
Member

  • adding orcidID to the contributors fields. It's added to nameIdentifiers list in to_datacite function.

fixes #102

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #111 (8b3281d) into master (0099e5f) will decrease coverage by 6.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   96.61%   90.55%   -6.06%     
==========================================
  Files          18       18              
  Lines        1564     1567       +3     
==========================================
- Hits         1511     1419      -92     
- Misses         53      148      +95     
Flag Coverage Δ
unittests 90.55% <33.33%> (-6.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/tests/test_datacite.py 48.88% <ø> (-51.12%) ⬇️
dandischema/datacite.py 50.90% <33.33%> (-44.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0099e5f...8b3281d. Read the comment docs.

@djarecka
Copy link
Member Author

I'm not sure why codecov does't like me...

dandischema/models.py Outdated Show resolved Hide resolved
@satra satra merged commit ffa49ef into dandi:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add orcid to contributor/creator metadata when available
2 participants