Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dandi:dandi-zarr-checksum digest #108

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Add dandi:dandi-zarr-checksum digest #108

merged 2 commits into from
Jan 10, 2022

Conversation

dchiquito
Copy link
Contributor

Add a new digest type dandi:dandi-zarr-checksum for representing the new zarr checksum digest.

@dchiquito dchiquito requested a review from satra January 7, 2022 20:50
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #108 (f677479) into master (7e53e9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          16       16           
  Lines        1453     1453           
=======================================
  Hits         1400     1400           
  Misses         53       53           
Flag Coverage Δ
unittests 96.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandischema/model_types.py 100.00% <ø> (ø)
dandischema/tests/test_models.py 95.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e53e9f...f677479. Read the comment docs.

@satra
Copy link
Member

satra commented Jan 8, 2022

@jwodder - there appears to be a few CLI failures that seem unrelated to this change.

@jwodder
Copy link
Member

jwodder commented Jan 8, 2022

@satra I believe those are all due to the latest release of dandi not including dandi/dandi-cli#854.

@satra
Copy link
Member

satra commented Jan 8, 2022

thank you @jwodder

@jwodder jwodder added the minor Increment the minor version when merged label Jan 10, 2022
@jwodder
Copy link
Member

jwodder commented Jan 10, 2022

@satra Could this be merged & released soon? The lack of this digest type value is one of the more concrete blockers for Zarr support in dandi-cli.

@satra satra removed the minor Increment the minor version when merged label Jan 10, 2022
@satra satra merged commit f3e587a into master Jan 10, 2022
@satra satra deleted the dandi-zarr-checksum branch January 10, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants