Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Minimize the number of highlighted blocks #521

Closed
duongdominhchau opened this issue Feb 10, 2021 · 2 comments
Closed

🚀 Minimize the number of highlighted blocks #521

duongdominhchau opened this issue Feb 10, 2021 · 2 comments

Comments

@duongdominhchau
Copy link

image

Here we can see delta highlights three blocks, but in this case only two is enough to show the change: one for <a id="Seconds.fraction"> and one for </a>. In this example, we can reduce the number of highlighted blocks by moving these blocks to the left as far as possible and merge.

@dandavison
Copy link
Owner

Hi @duongdominhchau, thanks for this. You're definitely right that the highlighting algorithm could be improved, and your example is very helpful. So it's a worthwhile project for me or anyone else to work on! #246 is similar, and #140 is related.

@dandavison
Copy link
Owner

I'm going to close this one and keep #246 as the primary ticket for this work, but thanks for the additional detail here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants