Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort and Limit incorrect for trades when using ?market=all #9

Closed
dan-da opened this issue Nov 9, 2017 · 1 comment
Closed

Sort and Limit incorrect for trades when using ?market=all #9

dan-da opened this issue Nov 9, 2017 · 1 comment

Comments

@dan-da
Copy link
Owner

dan-da commented Nov 9, 2017

The ?market=all option is implemented by calling the trades::get_trades() method once for each basecurrency and then aggregating results. The get_trades() method applies sort and limit params.

However, the original code was not applying sort and limit after the aggregation.

These sorts of complications are a consequence of the fact that the web ui and api is hiding the messiness of multiple basecurrencies in the underlying data source (bisq app).

@dan-da
Copy link
Owner Author

dan-da commented Nov 9, 2017

fixed in db6db6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant