Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we control the dimension of the popup that the authorizeWithPopUp method opens? #1043

Closed
Sudharsan-Narayanasamy opened this issue Apr 12, 2021 · 8 comments

Comments

@Sudharsan-Narayanasamy
Copy link

How do we control the dimension of the popup that the authorizeWithPopUp method opens ? Is it possible ?

I see that the LoginService exposes a method called loginWithPopUp that takes in popupOptions as an additional argument. But I am not sure of how to use it. Not much documentation on this. How different is this method compared to authorizeWithPopUp ?

Can you please clarify ?

@damienbod
Copy link
Owner

You can pass the options as a param and the options are set as follows:

const popupDefaultOptions = { width: 500, height: 500, left: 50, top: 50 };

So just pass what you need.

Greetings Damien

@FabianGosebrink FabianGosebrink changed the title Query - authorizeWithPopUp How do we control the dimension of the popup that the authorizeWithPopUp method opens? Apr 13, 2021
@FabianGosebrink
Copy link
Collaborator

FabianGosebrink commented Apr 13, 2021

Maybe we can document this better. Ah and I forgot to expose the options! fixing this now.

@Sudharsan-Narayanasamy
Copy link
Author

Thank you @FabianGosebrink . Will pull the latest package and give it a try.

@FabianGosebrink
Copy link
Collaborator

Please see the attached PR: It is not merged yet. Please stay tuned here :)

@damienbod
Copy link
Owner

@Sudharsan-Narayanasamy Will be released in the next minor version, Thanks for reporting.

Greetings Damien

@Sudharsan-Narayanasamy
Copy link
Author

@damienbod Thanks for the update. Do you have any time frame on when it will be released ?

@damienbod
Copy link
Owner

Hi @Sudharsan-Narayanasamy It will probably be Friday or Saturday, I would like to get 2 other small fixes into the release, hope this is ok

Greetings Damien

@Sudharsan-Narayanasamy
Copy link
Author

Thank you @damienbod . Absolutely okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants