-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition internal structs to Protocol Buffer Schema #440
Comments
Hi, @yohamta I am also in favor of the transition to Protocol Buffer and the gradual transition from Protocol Buffer to gRPC. May I work on it? |
Hi @garunitule , that would be really helpful! Please, go ahead and thank you so much for your support! |
@yohamta I would like to discuss how to handle the OutputVariables field (*utils.SyncMap type) in the Step type. I could only think of wrapping the type generated by protocol buffers and adding an OutputVariables field. |
Hi @garunitule 👋 Thank you for working on this! I suggest changing the OutputVariables type to a regular map and using a
Agreed 🙂 |
@yohamta |
Sorry, let me close this issue for now. We’ll keep JSON format for now to prioritize feature implementation to go to cloud. |
Considering transitioning our structs for basic information like Dag, Step, and Status to a Protocol Buffer schema. This change is expected to offer several advantages in the future, including:
I think it is a good stepping stone towards a gRPC-based client-server architecture that will make it easier to implement features to manage remote servers from local machines.
The text was updated successfully, but these errors were encountered: