Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Modular DAG #373

Closed
GhisF opened this issue Nov 29, 2022 · 6 comments
Closed

[Feature Request] Modular DAG #373

GhisF opened this issue Nov 29, 2022 · 6 comments

Comments

@GhisF
Copy link

GhisF commented Nov 29, 2022

It is not uncommon to have several versions of a DAG with only minor variations. It could be interesting to have the possibility to import steps or call other DAGs to avoid copy/paste between dags.

@yottahmd
Copy link
Collaborator

Thanks for the great suggestion. Yes, as you mentioned there're two different approaches to dealing with the issue.
I think calling other DAGs (or sub-DAGs) natively looks like a good idea.

@yottahmd yottahmd changed the title Modular DAG [Feature Request] Modular DAG Mar 25, 2023
@ccxuy
Copy link

ccxuy commented May 11, 2024

any updates?

@yottahmd
Copy link
Collaborator

Not yet. While importing steps or calling other DAGs to avoid copy/paste between DAGs is an interesting idea, I think that allowing the direct importing of other DAGs in YAML could lead to some complications and potential issues with maintainability.

As an alternative, you can currently call other DAGs (or sub-DAGs) using the dagu start command.

We can continue to explore ways to improve the reusability and modularity of DAGs. Any suggestion or ideas are very welcomed.

@yottahmd
Copy link
Collaborator

my idea:

steps:
  - sub_workflow1
     run: path/to/sub_workflow.yaml
     params: "A=1 B=2"

@GhisF
Copy link
Author

GhisF commented May 13, 2024

It looks like a good idea.

@yottahmd
Copy link
Collaborator

This feature is implemented in v1.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants