Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dag table a11y issues #336

Merged
merged 2 commits into from
Sep 18, 2022

Conversation

RamonEspinosa
Copy link
Contributor

Description

This PR solves some accessibility issues in the DAG Table.

The problem

I ran an audit using Wave and found that there where some elements that had no text nor labels assigned. This is a problem for users who have low visibility issues and prefer to use screen readers because, provided they stumble upon one of these elements, the screen reader will skip the element, resulting in a bad user experience.

The solution

  1. Added aria-label attributes to input elements that had no labels.
  2. Added a VisuallyHidden component to render text for screen readers.

Screenshots

Before

Screen Shot 2022-09-17 at 11 06 06-fullpage
Screen Shot 2022-09-17 at 11 04 11-fullpage

After

Screen Shot 2022-09-17 at 11 05 54
Screen Shot 2022-09-17 at 11 06 53

@codecov-commenter
Copy link

Codecov Report

Base: 85.21% // Head: 85.29% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (c1d8af8) compared to base (a1f4e74).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   85.21%   85.29%   +0.08%     
==========================================
  Files          45       45              
  Lines        3564     3564              
==========================================
+ Hits         3037     3040       +3     
+ Misses        385      381       -4     
- Partials      142      143       +1     
Impacted Files Coverage Δ
internal/controller/controller.go 75.74% <0.00%> (+1.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yottahmd
Copy link
Collaborator

Thanks for the fantastic improvement! I didn't know the Wave, but it looks very handy :)

@yottahmd yottahmd merged commit a7b9e6e into dagu-org:main Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants