Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parameter parsing issue #165

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: parameter parsing issue #165

merged 1 commit into from
Jun 13, 2022

Conversation

yottahmd
Copy link
Collaborator

@yottahmd yottahmd commented Jun 13, 2022

Closes #164

@yottahmd yottahmd force-pushed the fix/parameter-parsing-issue branch from 8b0a3db to d84a848 Compare June 13, 2022 01:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #165 (9cd8eea) into main (9b42d4e) will increase coverage by 0.17%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   82.64%   82.81%   +0.17%     
==========================================
  Files          43       43              
  Lines        2938     2950      +12     
==========================================
+ Hits         2428     2443      +15     
+ Misses        375      373       -2     
+ Partials      135      134       -1     
Impacted Files Coverage Δ
internal/config/config.go 82.83% <94.44%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b42d4e...9cd8eea. Read the comment docs.

@yottahmd yottahmd force-pushed the fix/parameter-parsing-issue branch from d84a848 to 9cd8eea Compare June 13, 2022 01:43
@yottahmd yottahmd merged commit 65d796e into main Jun 13, 2022
@yottahmd yottahmd deleted the fix/parameter-parsing-issue branch June 13, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named parameter is not correctly parsed when it uses former param
2 participants