fix: action buttons on the DAG list page don't work for DAGs with custom names #625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a DAG has a custom name defined, the actions buttons on the DAG list page don't work as the frontend uses the custom name instead of the DAG file name to call the "Submit DAG Action" API (
POST /api/v1/dags/:name
).For example, given a DAG namely
test.yaml
as below:When the "Start the DAG" button is clicked from the DAG list page, the following API is called incorrectly:
POST /api/v1/dags/Custom Name
.Instead,
POST /api/v1/dags/test
should be called.To fix it, I simply extract the DAG filename without the
.yaml
extention name fromdata.DAGStatus.File
, and then use that as thename
property onDAGActions
.