made status of dags configurable #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yottahmd
reviewed
Apr 18, 2024
| @@ -307,9 +309,14 @@ func (store *Store) pattern(dagFile string) string { | |||
| return filepath.Join(dir, p) | |||
| } | |||
|
|
|||
| func (store *Store) latestToday(dagFile string, day time.Time) (string, error) { | |||
There was a problem hiding this comment.
I think we can use the following method instead of modifying this one:
We can modify the following code to use the ReadStatusRecent method according to the configuration:
yottahmd
approved these changes
Apr 24, 2024
|
thank you. i am sorry was not able to push changes |
|
no problem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
earlier it only show status of dags from that day, so when if I need to know latest status of dag irrespective of when did it ran last there is a variable defined in the config "latestStatusToday". If it is true, it will show latest status from that day, or it will show the latest status irrespective of when it ran