Add single document with tabs sample #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds a more advanced example collection schema for the single document collections. For investigation (issue raised by @jayraydon)
If it's a new document, the tabs work (check the href for the tabs, each one is built correctly with the format
{collection}/new/{tabName})The tabs also work immediately after saving a new document, when the document id has been pushed into the URL (they now have the format
/{collection}/{documentId}/tabName).The problem is that the tabs don't have the correct href when editing an existing document, and therefore can't be changed (they now have the format
/{collection})