Add support for single-document collections #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmoses
commented
Aug 4, 2019
|
A point for discussion: I removed the "Delete" button, because it didn't make much sense here, but maybe there should be something like "clear all fields" button? |
eduardoboucas
suggested changes
Aug 5, 2019
| return collection.slug === params.collection | ||
| }) | ||
|
|
||
| const isNewDocument = /\/new(\/|$)/.test(path) && !params.documentId |
There was a problem hiding this comment.
@ohmoses is there ever a case where checking for params.documentId is not enough to determine whether we're creating a new document?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #584
If
settings.publish.isSingleDocumentis set totruein the collection schema, Publish will show the document editor (instead of the document list) on route/collectionName(or/groupName/collectionName). If there are multiple documents in the collection, Publish will operate on the first one.I made a small change to enable
connectReduxto accept amapStatefunction, so that inReferenceSelectView,DocumentListView, andDocumentEditView, I could move the logic for creatingcontentKeys,documentId, etc., tomapStateand pass them to the components.