Add support for custom CSS file in workspace #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abovedave
reviewed
Jan 28, 2019
app/lib/router/index.js
Outdated
| // file in their workspace directory, we'll serve it. If not, | ||
| // we don't want to return a 404 for it. We simply return a | ||
| // blank CSS file. | ||
| if (req.url === '/public/custom.css') { |
There was a problem hiding this comment.
I'm not sure if this is needed @eduardoboucas. Don't we just need a blank custom.css in the public folder - that way if they're running from a direct download vs npm the solution still works?
There was a problem hiding this comment.
You’re right, that’s a very good point!
abovedave
reviewed
Jan 28, 2019
|
@jimlambie Happy for me to release this as 2.1.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.