Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local public folder #605

Merged
merged 10 commits into from
Nov 21, 2018
Merged

local public folder #605

merged 10 commits into from
Nov 21, 2018

Conversation

abovedave
Copy link
Contributor

@abovedave abovedave commented Nov 21, 2018 •
edited
Loading

Looks for whitelabel assets in /public/ folder first, if nothing there it goes to the node_modules local version.

Config defaults:

"whitelabel": {
    "backgroundImage": "bg.png",
    "logo": "logo.png",
    "poweredBy": false
}

N.B. logo.png and bg.png now live in the root of the public folder by default

closes #557

eduardoboucas
eduardoboucas approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! This is exactly what I wanted to do. Thanks for looking into it. Added just a few suggestions, mainly around removing the nested object destructuring syntax. 🚀

@eduardoboucas eduardoboucas merged commit 10dc08e into develop Nov 21, 2018
@abovedave abovedave deleted the patch/public-folder branch November 28, 2018 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoboucas eduardoboucas eduardoboucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspace public folder
2 participants
@abovedave @eduardoboucas