Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not installable on Node 10 #511

Closed
danwdart opened this issue Sep 25, 2018 · 6 comments · Fixed by #546
Closed

Not installable on Node 10 #511

danwdart opened this issue Sep 25, 2018 · 6 comments · Fixed by #546

Comments

@danwdart
Copy link
Contributor

Latest Publish isn't installable on Node 10 due to the ursa library in deep dependencies not yet running on it. Current workaround is to use Node 8 via nvm or similar.

Somebody made a fix for ursa itself but it hasn't yet been merged:

See also: JoshKaufman/ursa#167

Current Node supported version is 8, and should be 8 and 10 as of next Tuesday as per docs saying "Active LTS".

@danwdart
Copy link
Contributor Author

Looks like versions 0.10 and 0.10.1 are ok with Node 10 - so our dependencies that use those can just be updated as long as they point to those versions or higher, too.

@danwdart
Copy link
Contributor Author

It looks like it's just @dadi/ssl: https://github.com/dadi/ssl/blob/master/package.json#L22

@eduardoboucas
Copy link
Contributor

@jimlambie has removed that module, so we can close this one.

@danwdart
Copy link
Contributor Author

OK cool. I suppose the latest @dadi/ssl will have removed it instead of upgrading to the git version (seeing as not npm yet) so @dadi/publish needs to update to the newest @dadi/ssl?

@eduardoboucas
Copy link
Contributor

I meant we have removed @dadi/ssl.

@danwdart
Copy link
Contributor Author

ah oh right cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants