Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tournament.from_dict doesn't support multiple break categories #6

Closed
daankoning opened this issue Oct 27, 2022 · 3 comments
Closed

Tournament.from_dict doesn't support multiple break categories #6

daankoning opened this issue Oct 27, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@daankoning
Copy link
Owner

daankoning commented Oct 27, 2022 •
edited
Loading

DebaterJSON supports a list of strings as the value of break_categories. The program does not as of now.

The corresponding code in utils.generate_csv should also be updated accordingly.
@daankoning daankoning added the bug Something isn't working label Oct 27, 2022
@daankoning
Copy link
Owner Author

This is the offending line:

debater.py/src/debaterpy/structures.py

Line 78 in bbec95c

break_categories=data.get("break_categories"),

@daankoning
Copy link
Owner Author

The exact same problem applies to Round.topics.

@daankoning
Copy link
Owner Author

This bug doesn't exist

@daankoning daankoning mentioned this issue Oct 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daankoning