Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Including docker container information and a blank CMD field in an app JSON breaks PUT updates but not POST app creations #1630

Closed
john-dodson opened this issue Jun 9, 2015 · 3 comments
Milestone

Comments

@john-dodson
Copy link

If include Docker container information in your JSON and "cmd": "", then using POST to create the app in Marathon will work, but using PUT to update it throws the error:

"AppDefinition must either contain one of 'cmd' or 'args', and/or a 'container'."

If you remove the "cmd": "" from the JSON the PUT update for the app works.

Marathon should behave identically in both cases when "cmd": "" is provided, either throwing an error in both cases or never throwing an error for that. I would argue that it should not throw the error like the current functionality of the POST command.

@aquamatthias aquamatthias added this to the Backlog milestone Jun 16, 2015
@aquamatthias
Copy link
Contributor

Thanks @john-dodson for this report.
I could reproduce this behavior.
We have different data models for creation and update.
Obviously the validation logic is not congruent.

@kolloch
Copy link
Contributor

kolloch commented Jun 17, 2015

Hi @aquamatthias , isn't it a duplicated of #1446?
Did you test on master?

@aquamatthias
Copy link
Contributor

Duplicate of #1446 which is fixed in 0.9.0.

@aquamatthias aquamatthias modified the milestones: Backlog, 0.10.0 Jul 3, 2015
@d2iq-archive d2iq-archive locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants