Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Changing args to cmd triggers validation error #1222

Closed
bobrik opened this issue Feb 19, 2015 · 2 comments
Closed

Changing args to cmd triggers validation error #1222

bobrik opened this issue Feb 19, 2015 · 2 comments

Comments

@bobrik
Copy link
Contributor

bobrik commented Feb 19, 2015

I'm running master.

  1. Create app with container and args set.
  2. Decide that you want to pass $PORT, therefore you need to use cmd.
  3. Remove args, add cmd. Deploy.
AppDefinition must either contain one of 'cmd' or 'args', and/or a 'container'.

It is possible to remove app and deploy with cmd and container.

cc @drexin, possibly happened in #1201.

@drexin
Copy link
Contributor

drexin commented Feb 19, 2015

I think before #1201 it worked by accident. We have to provide a way to unset fields. PUT should override the whole app, which it currently doesn't and the behaviour it currently has needs to be exposed by a new PATCH endpoint.

@aquamatthias
Copy link
Contributor

The problem is, that you can not express unsetting values the way we provide the API.
See #1418

@d2iq-archive d2iq-archive locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants