Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-dev-server): import cypress client script asynchronously to avoid flake #15778

Merged
merged 2 commits into from
Apr 3, 2021

Conversation

elevatebart
Copy link
Contributor

remove vite-web-server flake with electron

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 3, 2021

Thanks for taking the time to open a PR!

@elevatebart elevatebart changed the title fix: load script test last to avoid flake fix(vite-web-server): import cypress client script asynchronously to avoid flake Apr 3, 2021
@cypress
Copy link

cypress bot commented Apr 3, 2021



Test summary

3987 0 49 2Flakiness 0


Run details

Project cypress
Status Passed
Commit 7bca981
Started Apr 3, 2021 1:35 AM
Ended Apr 3, 2021 1:45 AM
Duration 09:42 💡
OS Linux Debian - 10.5
Browser Chrome 83

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@elevatebart elevatebart changed the title fix(vite-web-server): import cypress client script asynchronously to avoid flake fix(vite-dev-server): import cypress client script asynchronously to avoid flake Apr 3, 2021
@JessicaSachs JessicaSachs self-requested a review April 3, 2021 03:01
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I love it when the answer is simple :-)

@JessicaSachs JessicaSachs merged commit 88a3830 into develop Apr 3, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 5, 2021

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants