Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Support video recording in browsers other than electron #745

Closed
Sumolari opened this issue Oct 16, 2017 · 4 comments
Closed

Proposal: Support video recording in browsers other than electron #745

Sumolari opened this issue Oct 16, 2017 · 4 comments
Labels
topic: video 📹 type: duplicate This issue or pull request already exists

Comments

@Sumolari
Copy link

From version 0.20.0 changelog...

There is a new --browser option that lets you change the browser that runs from the command line. This works the same way as changing the browser in the GUI, with the exception that any browser other than the default electron browser will not record a video. This is solvable but requires more work.

Is this going to be addressed in a future version?

@Sumolari Sumolari changed the title Proposal: Support video recording in browsers other than Chrome Proposal: Support video recording in browsers other than electron Oct 16, 2017
@brian-mann
Copy link
Member

Yes, we already ship ffmpeg and could use that to record the headed browsers. The code just needs to be updated to handle these different scenarios.

There's some complexity around situations where the user has 2 monitors, or they inadvertently record the wrong thing and upload it to the Dashboard. The video would likely be taken at maximum screen size resolution too, making these bigger than the usual videos taken. It's also possible to figure out the dimensions of the browser and to possibly just record that.

Launching in full screen would likely also need to be the default, and/or we'd need to expose a CLI flag for launching at a specific resolution.

@RandallKent RandallKent added help wanted stage: proposal 💡 No work has been done of this issue type: feature New feature that does not currently exist labels Oct 16, 2017
@gpenafib
Copy link

Hi Brian, could you please provide roughly a date when the recording video feature will be already implemented for Chrome browser?

@hally9k
Copy link

hally9k commented Mar 8, 2018

This is a feature that we will need in order to continue with cypress as electron doesn't seem to support EventSource for SSEs.

@RandallKent
Copy link
Contributor

Closing in favor of #1767

@jennifer-shehane jennifer-shehane added type: duplicate This issue or pull request already exists and removed help wanted stage: proposal 💡 No work has been done of this issue type: feature New feature that does not currently exist labels Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: video 📹 type: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

6 participants