Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check target Babel settings when transpiling CLI code #5799

Closed
bahmutov opened this issue Nov 26, 2019 · 2 comments · Fixed by #8938
Closed

Check target Babel settings when transpiling CLI code #5799

bahmutov opened this issue Nov 26, 2019 · 2 comments · Fixed by #8938
Assignees
@bahmutov
Labels
cli process: build Related to our internal build process type: breaking change Requires a new major release version

Comments

@bahmutov
Copy link
Contributor

Related to #5632 (comment)

Currently we transpile cli code using scripts/start-build.js. After upgrading to Node 8 we need to revisit transpile settings to avoid targeting Node 6 platform
@bahmutov bahmutov self-assigned this Nov 26, 2019
@bahmutov bahmutov added cli process: build Related to our internal build process labels Nov 26, 2019
@cypress-bot cypress-bot bot added the stage: needs investigating Someone from Cypress needs to look at this label Nov 27, 2019
@jennifer-shehane jennifer-shehane added the type: breaking change Requires a new major release version label Nov 27, 2019
@jennifer-shehane jennifer-shehane mentioned this issue Oct 23, 2020
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs investigating Someone from Cypress needs to look at this labels Oct 26, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 26, 2020

The code for this is done in cypress-io/cypress#8938, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@bahmutov
Copy link
Contributor Author

bahmutov commented Apr 7, 2021

Released in v5.5.0

@cypress-io cypress-io locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bahmutov bahmutov

Labels
cli process: build Related to our internal build process type: breaking change Requires a new major release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use modern cli compile target, remove unneeded polyfills cypress-io/cypress
2 participants
@jennifer-shehane @bahmutov