Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't skip a test with a done() callback #3403

Closed
kuceb opened this issue Feb 8, 2019 · 3 comments
Closed

Can't skip a test with a done() callback #3403

kuceb opened this issue Feb 8, 2019 · 3 comments
Labels
pkg/driver This is due to an issue in the packages/driver directory stage: needs investigating Someone from Cypress needs to look at this stale no activity on this issue for a long period type: bug

Comments

@kuceb
Copy link
Contributor

kuceb commented Feb 8, 2019 •
edited
Loading

this currently fails:

  it('can skip with done()', function (done) {
      this.skip()
  })

image

https://mochajs.org/#inclusive-tests

image
@cypress-bot cypress-bot bot added the stage: needs information Not enough info to reproduce the issue label Feb 8, 2019
@kuceb kuceb changed the title Error thrown when skipping a test with a done() callback Can't skip a test with a done() callback Feb 8, 2019
@cypress-bot cypress-bot bot added stage: needs investigating Someone from Cypress needs to look at this and removed stage: needs information Not enough info to reproduce the issue labels Feb 8, 2019
@jennifer-shehane
Copy link
Member

This displays a different error in upcoming v4.0 release (which includes Mocha upgrade).

Screen Shot 2019-07-13 at 9 31 33 AM

@jennifer-shehane jennifer-shehane added the type: unexpected behavior User expected result, but got another label Jul 13, 2019
@jennifer-shehane jennifer-shehane added type: bug pkg/driver This is due to an issue in the packages/driver directory and removed type: unexpected behavior User expected result, but got another labels Jan 5, 2021
@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label May 18, 2023
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg/driver This is due to an issue in the packages/driver directory stage: needs investigating Someone from Cypress needs to look at this stale no activity on this issue for a long period type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jennifer-shehane @kuceb @cypress-app-bot