Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desktop-gui): add utm parameters to external links #14741

Merged
merged 7 commits into from
Feb 1, 2021
Merged

Conversation

panzarino
Copy link
Contributor

@panzarino panzarino commented Jan 25, 2021

CANNOT BE MERGED UNTIL https://github.com/cypress-io/cypress-services/pull/3412 IS DEPLOYED

User facing changelog

No external changelog

Additional details

Adds UTM parameters to the links coming from the desktop-gui so we can get a better idea of how many people are clicking each of those links

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 25, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jan 25, 2021



Test summary

3967 1 52 1


Run details

Project cypress
Status Failed
Commit 471bd72
Started Jan 27, 2021 4:59 AM
Ended Jan 27, 2021 5:11 AM
Duration 12:12 💡
OS Linux Debian - 10.5
Browser Firefox 77

View run in Cypress Dashboard ➡️


Failures

cypress/integration/commands/xhr_spec.js Failed
1 ... > sets err on log when caused by the XHR response

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@panzarino panzarino marked this pull request as ready for review January 25, 2021 23:33
@panzarino panzarino changed the title fix(dashboard-gui): add utm parameters to external links fix(desktop-gui): add utm parameters to external links Jan 25, 2021
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panzarino It looks like you just missed the Services release. You may want to ask them to cherry pick the on links into master and release for you, because this can't go out until that's released. The /docs links will 404 otherwise.

Everything else in this PR looks fine to merge after that is deployed.

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream PR merged, merging

@flotwig flotwig merged commit 1aec4d0 into develop Feb 1, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 1, 2021

Released in 6.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 1, 2021
@emilyrohrbough emilyrohrbough deleted the add-utm-params branch August 1, 2024 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants