-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(desktop-gui): add utm parameters to external links #14741
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panzarino It looks like you just missed the Services release. You may want to ask them to cherry pick the on links into master and release for you, because this can't go out until that's released. The /docs links will 404 otherwise.
Everything else in this PR looks fine to merge after that is deployed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream PR merged, merging
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
CANNOT BE MERGED UNTIL https://github.com/cypress-io/cypress-services/pull/3412 IS DEPLOYED
User facing changelog
No external changelog
Additional details
Adds UTM parameters to the links coming from the desktop-gui so we can get a better idea of how many people are clicking each of those links
PR Tasks