Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Studio should not add .click() before .type() #14685

Closed
panzarino opened this issue Jan 22, 2021 · 2 comments · Fixed by #14694
Closed

Studio should not add .click() before .type() #14685

panzarino opened this issue Jan 22, 2021 · 2 comments · Fixed by #14694
Assignees
@panzarino
Labels
experiment: studio Issues when using experimentalStudio type: enhancement Requested enhancement of existing feature

Comments

@panzarino
Copy link
Contributor

panzarino commented Jan 22, 2021 •
edited
Loading

Current behavior

Currently Studio will add a cy.click() before a cy.type() when an input is clicked. However, Cypress automatically clicks an input before typing, so it's redundant for studio to generate this command.

ezgif-3-551b311e75cd

Desired behavior

Studio should not add a cy.click() before a cy.type() (on the same element)
@panzarino panzarino added type: enhancement Requested enhancement of existing feature experiment: studio Issues when using experimentalStudio labels Jan 22, 2021
@panzarino panzarino self-assigned this Jan 22, 2021
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jan 22, 2021
@panzarino panzarino mentioned this issue Jan 22, 2021
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Jan 22, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 27, 2021

The code for this is done in cypress-io/cypress#14694, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jan 27, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 1, 2021

Released in 6.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@panzarino panzarino

Labels
experiment: studio Issues when using experimentalStudio type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: studio no longer generates .click() before .type() cypress-io/cypress
1 participant
@panzarino