Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct imap buttons on servers page & trigger change sieve_mode_tls checkbox on edit server #1289

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

Shadow243
Copy link
Member

@Shadow243 Shadow243 commented Oct 19, 2024

Follow up to #1199 & #1266

@Shadow243 Shadow243 force-pushed the imap_sieve_mode_tls branch 3 times, most recently from 1f1b212 to 8d5d0e9 Compare October 19, 2024 18:11
@Shadow243 Shadow243 changed the title trigger change sieve_mode_tls checkbox on edit server Correct imap buttons on servers page & trigger change sieve_mode_tls checkbox on edit server Oct 19, 2024
@Shadow243 Shadow243 force-pushed the imap_sieve_mode_tls branch from 8d5d0e9 to 398b553 Compare October 19, 2024 18:26
@Shadow243 Shadow243 force-pushed the imap_sieve_mode_tls branch from 398b553 to 452652a Compare October 19, 2024 18:30
@Shadow243 Shadow243 merged commit e61afbb into cypht-org:master Oct 19, 2024
6 checks passed
@mercihabam
Copy link
Member

@Shadow243 I am skeptical as to why the pipeline succeeded here while containing mistakes to the test, showing up in follow-up pull requests. Does the pipeline run on cached content?

@Shadow243
Copy link
Member Author

@Shadow243 I am skeptical as to why the pipeline succeeded here while containing mistakes to the test, showing up in follow-up pull requests. Does the pipeline run on cached content?

It's weird, this test doesn't work sometimes, I even opened another PR #1290 to fix this, with the same fix you applied my test didn't pass. let's see if it won't break anymore.

@mercihabam
Copy link
Member

@Shadow243 I am skeptical as to why the pipeline succeeded here while containing mistakes to the test, showing up in follow-up pull requests. Does the pipeline run on cached content?

It's weird, this test doesn't work sometimes, I even opened another PR #1290 to fix this, with the same fix you applied my test didn't pass. let's see if it won't break anymore.

As for the test, it is stable. Reintroducing the line self.wait_for_navigation_to_complete() worked for you as well, but you encountered a separate test failure that was fixed with this change.

It is still confusing that the pipeline sometimes runs against old content (seemingly from the master branch) rather than the actual branch state.

@Shadow243
Copy link
Member Author

Shadow243 commented Oct 21, 2024

@Shadow243 I am skeptical as to why the pipeline succeeded here while containing mistakes to the test, showing up in follow-up pull requests. Does the pipeline run on cached content?

It's weird, this test doesn't work sometimes, I even opened another PR #1290 to fix this, with the same fix you applied my test didn't pass. let's see if it won't break anymore.

As for the test, it is stable. Reintroducing the line self.wait_for_navigation_to_complete() worked for you as well, but you encountered a separate test failure that was fixed with this change.

It is still confusing that the pipeline sometimes runs against old content (seemingly from the master branch) rather than the actual branch state.

Super, i then close #1290. We will find out what is making pipeline to run against old content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants